Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix link font size to inherit #11770

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

ajkl2533
Copy link
Contributor

@ajkl2533 ajkl2533 commented Aug 3, 2020

Issue: #11393

What I did

My problem was that when I included a link in heading (in Markdown) the font size of the link was smaller than the heading itself because links had font size hardcoded and set to (14px). I changed the font-size property to inherit so now the links should have the same size as the parent block.

Before

Screenshot 2020-08-03 at 14 03 36

After

Screenshot 2020-08-03 at 14 02 40

How to test

  • Is this testable with Jest or Chromatic screenshots? yes, Chromatic
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!! 🙏

@shilman shilman changed the title fix(DocumentFormatting): inherit font size in links Addon-docs: Fix link font size to inherit Aug 3, 2020
@shilman shilman added this to the 6.0 milestone Aug 3, 2020
@shilman shilman merged commit 8eb9ce7 into storybookjs:next Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants